Skip to content

Avoid some unnecessary buffering when reading config file #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

Avoid some unnecessary buffering when reading config file #2215

merged 1 commit into from
Apr 19, 2023

Conversation

andrewmbenton
Copy link
Collaborator

No description provided.

golightlyb
golightlyb suggested changes Apr 19, 2023
View reviewed changes
Copy link

@golightlyb golightlyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this now missing a defer file.Close()? Best wishes

@andrewmbenton
Copy link
Collaborator Author

Good catch, I've updated this PR with that addition.

@kyleconroy kyleconroy merged commit d70dc32 into sqlc-dev:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleconroy kyleconroy kyleconroy approved these changes

+1 more reviewer

@golightlyb golightlyb golightlyb requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewmbenton @kyleconroy @golightlyb